Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CursorColumn is not visible when let g:solarized_contrast = "low" #217

Open
rysktky opened this issue May 15, 2020 · 1 comment
Open

CursorColumn is not visible when let g:solarized_contrast = "low" #217

rysktky opened this issue May 15, 2020 · 1 comment

Comments

@rysktky
Copy link

rysktky commented May 15, 2020

Normal and CursorColumn has same background color when 'let g:solarized_contrast = "low"'
This makes CursorColumn invisible.

:echo &background
dark
:hi Normal
Normal         xxx ctermfg=12 ctermbg=0
:hi CursorColumn
CursorColumn   xxx ctermbg=0 guibg=Grey40

:echo &background
light
:hi Normal
Normal         xxx ctermfg=11 ctermbg=7
:hi CursorColumn
CursorColumn   xxx ctermbg=7 guibg=Grey90

Maybe set it to 8 and 15 for dark and light?
GUI has the same problem too.

@rysktky
Copy link
Author

rysktky commented May 16, 2020

OK, lazy way could be this.
This will set base03 to CursorColumn, CursorLine, LineNr as well.
Visual gets revers with proper contrast as well.

--- a/colors/solarized.vim
+++ b/colors/solarized.vim
@@ -406,7 +406,9 @@ if g:solarized_contrast == "high"
 endif
 if g:solarized_contrast == "low"
     let s:back        = s:base02
-    let s:ou          = ",underline"
+    let s:temp02      = s:base02
+    let s:base02      = s:base03
+    let s:base03      = s:temp02
 endif
 "}}}
 " Overrides dependent on user specified values and environment "{{{

Or the original did not do like above in order to make it less colorful.
Then maybe we can write if-statement for each highlight like this.

--- a/colors/solarized.vim
+++ b/colors/solarized.vim
@@ -667,7 +667,11 @@ exe "hi! PmenuThumb"     .s:fmt_none   .s:fg_base0  .s:bg_base03  .s:fmt_revbb
 exe "hi! TabLine"        .s:fmt_undr   .s:fg_base0  .s:bg_base02  .s:sp_base0
 exe "hi! TabLineFill"    .s:fmt_undr   .s:fg_base0  .s:bg_base02  .s:sp_base0
 exe "hi! TabLineSel"     .s:fmt_undr   .s:fg_base01 .s:bg_base2   .s:sp_base0  .s:fmt_revbbu
+if ( solarized_contrast == 'low' )
+exe "hi! CursorColumn"   .s:fmt_none   .s:fg_none   .s:bg_base03
+else
 exe "hi! CursorColumn"   .s:fmt_none   .s:fg_none   .s:bg_base02
+endif
 exe "hi! CursorLine"     .s:fmt_uopt   .s:fg_none   .s:bg_base02  .s:sp_base1
 exe "hi! ColorColumn"    .s:fmt_none   .s:fg_none   .s:bg_base02
 exe "hi! Cursor"         .s:fmt_none   .s:fg_base03 .s:bg_base0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant