Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

absorb collectors into readers #33

Open
6 tasks done
TaiSakuma opened this issue Mar 3, 2018 · 3 comments
Open
6 tasks done

absorb collectors into readers #33

TaiSakuma opened this issue Mar 3, 2018 · 3 comments

Comments

@TaiSakuma
Copy link
Member

TaiSakuma commented Mar 3, 2018

related to the comment at https://github.com/alphatwirl/alphatwirl-interface/pull/7#issuecomment-369357995

this will be surgical changes.

it will help to solve #10.

steps:

@TaiSakuma
Copy link
Member Author

TaiSakuma commented Jul 28, 2018

  • add collect() to ReaderComposite f8b8f92
  • add option collector and method collect() to Reader 9be4939

@TaiSakuma
Copy link
Member Author

TaiSakuma commented Aug 9, 2018

The collectors are actually doing two things

  1. collect results for multiple data sets
  2. collect results from multiple jobs for the same data set

The original purpose of the collectors was 1. In early versions of alphatwirl, there only was one job for one data set. The 2 wasn't necessary. The collectors started doing 2 as well when it became possible to split a job for one data set.

It is not easy to include 1 into readers because readers are unaware of data sets.

It is relatively easy to include 2 into readers.

@TaiSakuma
Copy link
Member Author

  • add collect() to AllwCount, AnywCount, NotwCount 2f1ccdf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant