Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more examples to website #8

Open
2 of 3 tasks
jasmainak opened this issue Oct 26, 2018 · 8 comments
Open
2 of 3 tasks

add more examples to website #8

jasmainak opened this issue Oct 26, 2018 · 8 comments

Comments

@jasmainak
Copy link
Member

jasmainak commented Oct 26, 2018

I think it would be useful to have more examples on the website and make it more pedagogic if we want neuro folks to adopt our code. Just a few ideas here:

  • dipole fit on motor rhythm in MNE sample data
  • show recovered artifacts on MNE sample data
  • simulated and recovered atoms for multivariate CSC

happy to help if needed :)

@TomDLT
Copy link
Collaborator

TomDLT commented Nov 5, 2018

I added a new example on MNE sample data, using multivariate CSC with a rank-1 constraint.

A selection of learned atoms:

  • heartbeat and eyeblink artifacts
  • evoked response, whose activations are synchronized with events
  • non-sinusoidal waveforms

@TomDLT
Copy link
Collaborator

TomDLT commented Nov 5, 2018

happy to help if needed :)

PR welcome :)

@TomDLT
Copy link
Collaborator

TomDLT commented Nov 6, 2018

@agramfort
Copy link
Collaborator

agramfort commented Nov 7, 2018 via email

@jasmainak
Copy link
Member Author

alright! I'll make a PR.

@jasmainak
Copy link
Member Author

jasmainak commented Nov 8, 2018

So, I looked into this. I tried running the sample data example and it took around 30 minutes to run on my box. It seems a bit of overkill to create another example which takes 30 minutes just to show them the dipole fit.

I was thinking that we could save the atoms in one example and then when building, enforce an order on how they are run using sphinx gallery configuration. This would mean that the examples are not self-contained but it will do the job of showing people how to fit dipoles on the learned atoms. Let me know if this sounds reasonable to you.

@agramfort
Copy link
Collaborator

agramfort commented Nov 9, 2018 via email

@jasmainak
Copy link
Member Author

okay sounds good. See #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants