Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GreedyCDL vs BatchCDL vs learn_d_z for univariate signals #27

Open
jasmainak opened this issue Oct 24, 2019 · 2 comments
Open

GreedyCDL vs BatchCDL vs learn_d_z for univariate signals #27

jasmainak opened this issue Oct 24, 2019 · 2 comments

Comments

@jasmainak
Copy link
Member

jasmainak commented Oct 24, 2019

I was trying to help someone use alphaCSC and realized that it's not straightforward to understand which class to use when. We are also missing some guidelines how to tweak certain parameters (e.g., which solver to choose?).

Empirically it seems that LGCD is better but it is not possible to use it from learn_d_z. I think this function should be deprecated and either GreedyCDL or BatchCDL should be supported also for univariate signals. Zen of Python says:

There should be one-- and preferably only one --obvious way to do it.

The GreedyCDL class should be documented in api.rst. And to use it for univariate signals, one needs to set rank1=False and uv_constraint='joint'.

In the same vein, split_signal is supported only for 2D signals at the moment, but extending it to 1D data will increase the user base with very little effort. Some efforts in making these things consistent would be great!

@agramfort
Copy link
Collaborator

agramfort commented Oct 24, 2019 via email

@tomMoral
Copy link
Contributor

I can look it up next week (once dicodile is finished ;) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants