Disable part of the threadpool test for TSAN #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
force-pushed
the
coretest
branch
from
83499ff
to
99aa408
Compare
bernhardmgruber
force-pushed
the
coretest
branch
from
99aa408
to
ce34b05
Compare
j-stephan
reviewed
Aug 29, 2023
| @@ -16,6 +22,10 @@ TEST_CASE("threadpool", "[core]") | |||
|
|
|||
| CHECK_THROWS_AS(f1.get(), std::runtime_error); | |||
|
|
|||
| #ifdef TSAN | |||
| # warning "Part of the threadpool test fails the TSAN CI and is therefore disabled." | |||
| // TODO(bgruber): Revisit this in the future on a new CI image. This problem does not happen locally. | |||
There was a problem hiding this comment.
Interesting. So probably some Ubuntu 20.04 issue then?
There was a problem hiding this comment.
I have no idea. It does not happen on my Ubuntu 23.04. Also interestingly, the CI reports a higher BOOST_LIB_STD_GNU than my local run :D In any case, all I can do is disable the test and add this note. Let's have a look again on newer Ubuntu images.
j-stephan
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2101.