Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump intl to v.0.18.0 #222

Open
fidoaf opened this issue Apr 18, 2023 · 9 comments
Open

Bump intl to v.0.18.0 #222

fidoaf opened this issue Apr 18, 2023 · 9 comments

Comments

@fidoaf
Copy link

fidoaf commented Apr 18, 2023

This is more of a request than an issue. It would be very helpful and not such an overhead to upgrade the dependecy with package intl to v0.18.0.

Let me know your thoughts.

@fidoaf fidoaf changed the title Bump int to v.0.18.0 Bump intl to v.0.18.0 Apr 18, 2023
@pchasco
Copy link

pchasco commented Apr 18, 2023

I second this

@itsahmed-dev
Copy link

I don't know if my issue is similar but I've custom locale defined in the material app already so I don't understand how device preview locale will also work as only one locale can be defined.

@bradrushworth
Copy link

Because no versions of device_preview match >1.1.0 <2.0.0 and device_preview 1.1.0 depends on flutter_localizations from sdk, device_preview ^1.1.0 requires flutter_localizations from sdk.
And because every version of flutter_localizations from sdk depends on intl 0.18.0, device_preview ^1.1.0 requires intl 0.18.0.
So, because nuptialflight depends on both intl ^0.17.0 and device_preview ^1.1.0, version solving failed.

@mikhael28
Copy link

I think this package is pretty feature complete in general - if you want, you should fork your own version, upgrade or downgrade the dependency, and run your version directly. I'm not sure what else the author could really do to improve this package aside from occasionally improving some random things here and there. It's a masterpiece.

@fidoaf
Copy link
Author

fidoaf commented May 23, 2023

I think this package is pretty feature complete in general - if you want, you should fork your own version, upgrade or downgrade the dependency, and run your version directly. I'm not sure what else the author could really do to improve this package aside from occasionally improving some random things here and there. It's a masterpiece.

@mikhael28, that was my intention but, browsing through the plugin's code, I cannot find where to upgrade intl dependency.
Could you please guide me?

@bradrushworth
Copy link

I think this package is pretty feature complete in general - if you want, you should fork your own version, upgrade or downgrade the dependency, and run your version directly. I'm not sure what else the author could really do to improve this package aside from occasionally improving some random things here and there. It's a masterpiece.

@mikhael28, that was my intention but, browsing through the plugin's code, I cannot find where to upgrade intl dependency. Could you please guide me?

It is inherited via the version of the flutter language. I've already fixed this issue in #225 though

@rbdog
Copy link

rbdog commented Jul 27, 2023

I have made updates for compatibility and released a new package. This is for sharing, not for promotional purposes. I hope it doesn't hinder any discussions.

Package: device_preview_minus

@Yetispapa
Copy link

@rbdog Is it feasible to update the intl version to ^0.18.1 and push an update to your package? This happens to be the latest version available.

@rbdog
Copy link

rbdog commented Sep 6, 2023

Hi, @Yetispapa

@rbdog Is it feasible to update the intl version to ^0.18.1 and push an update to your package? This happens to be the latest version available.

  • My package doesn't restrict the version.
  • It's possible that Flutter on your PC might be forcing the use of intl 0.18.0.
  • Please try the following command:
# use the latest Flutter
flutter upgrade -–force 
# remove the cache for forced version packages
flutter update-packages --force-upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants