Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio 2015 and 2017 libprotobuf for debug is missing (e. g. csgo) #36

Open
thewavelength opened this issue Sep 9, 2017 · 5 comments

Comments

@thewavelength
Copy link

See branch on csgo @ lib\win32\debug and compare to lib\win32\release

@psychonic
Copy link
Member

This is semi-intentional.

The debug libraries are up to twice the size of the release ones and not required for a regular build. Neither are handled that well by git.

Typically, if someone is capable of compiling and debugging, they are also able to compile their own local copy of the protobuf library as well.

(That's not to say that we won't add them, and I'm not going to close this out, but that was my own reasoning for not adding them. Not sure how the other team members feel.)

@thewavelength
Copy link
Author

Thanks, the explanation makes definitely sense.
I know Git is not intended for binary files and I already wondered that the release-versions of the library are included.

In the meantime I'll compile the lib on my own and will wait what the other team members will say.

If I can help here in any way (e. g. compile/upload VS2017 version for you), let me know :-)

@KyleSanderson
Copy link
Member

We could use https://git-lfs.github.com/ to host these bins; maybe.

@ghost
Copy link

ghost commented Apr 15, 2019

We could use https://git-lfs.github.com/ to host these bins; maybe.

Yeah, there's really no reason to not have them because of git lfs.

@psychonic
Copy link
Member

Adding via Git LFS sounds fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants