Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new contributor under the current pull request #785

Open
Piedone opened this issue Apr 8, 2024 · 2 comments
Open

Add new contributor under the current pull request #785

Piedone opened this issue Apr 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Piedone
Copy link

Piedone commented Apr 8, 2024

Is your feature request related to a problem? Please describe.
When asking the bot to add a new contributor in a comment under a pull request, it'll open a new pull request. This is unnecessary, and it'd be better to add the contributor's profile right there under the PR, i.e. together with the actual contribution.

If there's a CLA bot, it'll also cause issues by requesting the allcontributors bot to accept a CLA (like here, though the CLA bot's comment vanished for some reason).

Describe the solution you'd like
Add the contributor as a new commit under the current pull request.

Describe alternatives you've considered
We usually close the new PR and merge its branch into the original contribution's branch. This works, but it's a chore.

Additional context
I don't have any more.

@Piedone Piedone added the enhancement New feature or request label Apr 8, 2024
@1408eduardo
Copy link

Hi, Do you know how to deploy blockchains?

@Piedone
Copy link
Author

Piedone commented Apr 9, 2024

Bitcoin will fix this issue too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants