Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect arguments to SHAWrapFedex init method #698

Open
krishnakanthnakka opened this issue Sep 6, 2023 · 1 comment
Open

Incorrect arguments to SHAWrapFedex init method #698

krishnakanthnakka opened this issue Sep 6, 2023 · 1 comment

Comments

@krishnakanthnakka
Copy link

It seems like the SHAWrapFedex missed to take client_cfgs. Please check.

The Line

elif init_cfg.hpo.scheduler.startswith('wrap', client_cfgs):

    elif init_cfg.hpo.scheduler.startswith('wrap', client_cfgs):
        scheduler = SHAWrapFedex(init_cfg)

perhaps to be changed to

    elif init_cfg.hpo.scheduler.startswith('wrap'):
        scheduler = SHAWrapFedex(init_cfg, client_cfgs)
@rayrayraykk
Copy link
Collaborator

Thanks for the catching! The SHAWrapFedex will be deprecated in the future in #518 , but for now, adding client_cfgs is the correct solution to avoid errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants