Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a subfolder from the vault changes its nesting level #209

Open
uli-on opened this issue Jul 21, 2023 · 7 comments
Open

Removing a subfolder from the vault changes its nesting level #209

uli-on opened this issue Jul 21, 2023 · 7 comments

Comments

@uli-on
Copy link

uli-on commented Jul 21, 2023

Seems like removing a subfolder from the vault always moves it up onto the top level. I've tried with level one (sub) and two (sub-sub).

@uli-on
Copy link
Author

uli-on commented Jul 22, 2023

I forgot mentioning, this is manual order, not alphabetic, not by date, I didn't try these.

@alialbaali
Copy link
Owner

What do you think is the right way of handling that?

@uli-on
Copy link
Author

uli-on commented Jul 23, 2023 via email

@alialbaali
Copy link
Owner

alialbaali commented Jul 23, 2023

What I meant is that, if you have a folder, within another folder, and both of them are vaulted; Unvaulting the subfolder shouldn't unvault the parent, and that's why the unvaulted subfolder becomes a top level parent. However, if you unvault the top parent folder, any subfolders should get unvaulted too. Which is how currently it is implemented.

@uli-on
Copy link
Author

uli-on commented Jul 23, 2023 via email

@alialbaali
Copy link
Owner

The only thing that might need fixing is that, if you have a folder within a subfolder, and the parent isn't vaulted, but the child is, unvaulting the child should move it to be the child again, and not become a parent.

I think that's what you mean by creating this issue, right?

@uli-on
Copy link
Author

uli-on commented Jul 23, 2023

I'm not really versed with nested vaults, I've tried vaulting for the first time last week.

But since we have the "birds eye view" of the tree of nested folders, it looks as if it's quite easy to operate: you can access any folder from this perspective and give it a property (here: the vault, the quality "vaulted"). As a user with birds eye view, I don't care for what is vaulted on which level and what is not. This POV would immediately change if we could access " inner" folders of the vault (children) only by opening up outer folders (parents), i.e. if nested folders would be displayed among notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants