Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a pinned note is selected and included in the merge, the result is always a pinned note! #135

Open
AI-IMED opened this issue Sep 12, 2022 · 3 comments

Comments

@AI-IMED
Copy link

AI-IMED commented Sep 12, 2022

I see that the correct way is that the result of the merge depends on the first note in the sequential selection. If the first note in the sequential selection is (pinned) the result will be a pinned note, and if the first note in the sequential selection is (Unpinned), the result will be Unpinned note

@alialbaali
Copy link
Owner

The thing here is that, merging is sequential. For example, let's say that the user wants to merge the unpinned note first with a pinned note. In the current implementation, it would result in a pinned note. However, in your implementation, it would result in an unpinned note.

@AI-IMED
Copy link
Author

AI-IMED commented Sep 13, 2022

However, in your implementation, it would result in an unpinned note

Don't you think that makes sense for the time being, instead of consideration all the notes resulting from the merge as (pinned) as it is happening now

@alialbaali
Copy link
Owner

I think it is a flaw in the implementation, if it's done like that. I'm leaving this open, so we can get more opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants