Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements should not call into the various Printers #64

Open
ali1234 opened this issue Feb 1, 2021 · 0 comments
Open

Elements should not call into the various Printers #64

ali1234 opened this issue Feb 1, 2021 · 0 comments
Labels
Projects

Comments

@ali1234
Copy link
Owner

ali1234 commented Feb 1, 2021

Currently each element has various methods to convert a packet into ANSI, or HTML etc. This prevents feeding codepage information to the conversion process, because packets are not aware of each other. Instead, each Element should have one method to return it's displayable data as teletext bytes, and then the top level Packet object should handle conversion. This will avoid having to pass around a lot of state and reduce the amount of boilerplate code in the Elements.

Needed for #63

@ali1234 ali1234 added this to To do in v3.2.0 via automation Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
v3.2.0
  
To do
Development

No branches or pull requests

1 participant