Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cyrillic render to HTML #60

Closed
wants to merge 5 commits into from

Conversation

ZXByteman
Copy link
Contributor

Hi Ali,

There is a bit rough implementation for cyrillic support in html render. Oprion "cyrillic" was added, character set is Cyrillic G0 Set - Option 2 (Russian/Bulgarian).

Regards,
Alexander

@ZXByteman
Copy link
Contributor Author

I've forgot to mention that in this fix I've also submitted a change to header render, I've shifted page number one letter to the left because on many services this page number was "glued" to the header title. Like this:

image

@ali1234
Copy link
Owner

ali1234 commented Dec 1, 2020

The thing with "P100" is actually a bug. Last commit to that line broke it.

The rest of this I feel should be implemented in a way that allows to easily add more code pages. Probably by putting all the code pages into a dict and selecting one from the CLI.

@ZXByteman
Copy link
Contributor Author

Hi Ali,

I've made an update to "cyrillic" branch. Now "--cyrillic" switch is replaced with "--localcodepage" where codepage should be passed as string. Character set g0 was rearranged as a dict with "default" charset used as before and "cyr" charset used for "localcodepage". Polish, German etc. codepages could be added to have support for printing them to HTML.

Regards,
Alexander

@ali1234
Copy link
Owner

ali1234 commented Dec 15, 2020

Thanks!

It might be after Christmas before I can properly look at this and merge it.

@ZXByteman
Copy link
Contributor Author

Thank you, I'm looking forward to it :)

@ZXByteman
Copy link
Contributor Author

Hi Ali,

Let me kindly remind about my pull request 🙂

Thanks,
Alexander

@ali1234
Copy link
Owner

ali1234 commented Feb 1, 2021

Why is the default None instead of 'default'? Wouldn't that make it much easier?

@ali1234
Copy link
Owner

ali1234 commented Feb 1, 2021

Merging this as-is for now. I squashed the letter fix.

@ali1234 ali1234 closed this Feb 1, 2021
@ali1234 ali1234 linked an issue Feb 1, 2021 that may be closed by this pull request
@ZXByteman ZXByteman deleted the cyrillic branch February 3, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better codepage support
2 participants