Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

MirroredIndex:getObjectAsync is crashing #564

Open
robertmogos opened this issue Dec 6, 2018 · 0 comments
Open

MirroredIndex:getObjectAsync is crashing #564

robertmogos opened this issue Dec 6, 2018 · 0 comments

Comments

@robertmogos
Copy link
Contributor

robertmogos commented Dec 6, 2018

Do you want to request a feature or report a bug?
Bug

Bug: What is the current behavior?

public Request getObjectAsync(final @NonNull String objectID, final @Nullable Collection<String> attributesToRetrieve, @Nullable RequestOptions requestOptions, @NonNull CompletionHandler completionHandler

In the MirroredIndex:getObjectAsync we allow attributesToRetrieve to be nullable.
If the index is mirrored we return a new OnlineOfflineGetObjectRequest.
In the constructor we are creating a new ArrayList from attributesToRetrieve.
When the later is null, it will result in a crash.

Bug: What is the expected behavior?

Not crashing would be pretty sweet.

Bug: Which versions?

Latest

Bug: How to reproduce ?

 mirroredIndex.getObjectAsync("my-awesome-id", new CompletionHandler() {
            @Override
            public void requestCompleted(JSONObject jsonObject, AlgoliaException e) {
                //...
            }
});
@robertmogos robertmogos changed the title MirrorIndex:getObjectAsync is crashing MirroredIndex:getObjectAsync is crashing Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant