Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data to collect still appears even after the fields are disabled / multiple choice (checkbox) #1332

Open
icougil opened this issue Feb 21, 2024 · 2 comments
Assignees
Labels

Comments

@icougil
Copy link

icougil commented Feb 21, 2024

Describe the bug
After disabling one of the fields you can include in the "Attendees' data to collect" section, it still appears in the reservation / public view (where the users could buy a ticket).

To Reproduce
Steps to reproduce the behaviour:

  1. Go to the admin web
  2. Inside the "Attendees' data to collect" section, choose a "Multiple choice (checkbox)" and deselect one of the elements you have added there previously
  3. Save the changes
  4. Go to the reservation/public view and try to buy a ticket. You will still see the previous values in the checkbox

Expected behaviour
We expect not to see the disabled element/s

Screenshots

  • Admin
image
  • Public
image

Desktop (please complete the following information):

  • OS: OSx
  • Browser: Chrome
  • Version: 121

Additional context
Side note/another bug?: we found that using the "&" as a Text value in the "Multiple choice (checkbox)" made it impossible to continue with the reservation and, therefore, not move to the buying page.

@syjer syjer added the bug label Feb 22, 2024
@syjer syjer self-assigned this Feb 22, 2024
@syjer
Copy link
Member

syjer commented Feb 22, 2024

hi @icougil , thank you reporting this bug: I'm able to reproduce the issue in the main branch.

However I'm not able to reproduce the '&' issue.

@syjer
Copy link
Member

syjer commented Feb 22, 2024

As a fix, we will do something similar, as it goes further than simply hide a field on the client side:

  • we should let the user that had already set this disabled value to view it and resend it, as the user may simply want to update the email or name, we could also gray out the disabled field, this imply that we also need to change the validation rule, as it must consider if the user has already set a disabled value before.
  • else we should hide it

On the client side: we should hide if there was no value already pre-set, else we display it gray.
On the backend: we should allow to re-send disabled value only if the user had already set that value.

This bug affect: checkbox and radiobutton. Select seems to be handled more correctly, but the proposed improvement should allow a more user intuitive flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants