Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Add option for 2-pass in windows shell #28

Open
PabloDons opened this issue Feb 19, 2022 · 1 comment
Open

[suggestion] Add option for 2-pass in windows shell #28

PabloDons opened this issue Feb 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@PabloDons
Copy link

PabloDons commented Feb 19, 2022

Currently the 2-pass command only works in linux systems. I'd like to suggest an option to select Windows shell for the 2-pass script. It would work like so:
Replace the /dev/null with the Windows equivalent NUL virtual path (see this SO answer). ffmpeg asks for permission to overwrite this file, so an always overwrite flag on the first pass would be wonderful.

Also in PowerShell, the bash && operator does not work. The equivalent -and operator messes with the pipes, so the best alternative I could find is this:

ffmpeg -i input.mp4 -pass 1  -f mp4 -y nul; if ($?) { ffmpeg -i input.mp4 -pass 2 utput.mp4 }

NOTE: Not sure how this would look in command-prompt (cmd.exe). This would only work on powershell

@alfg
Copy link
Owner

alfg commented Feb 19, 2022

Hey @PabloDons, thanks for the suggestion. This is something I can probably add as a toggle setting in the options menu. I'll keep this open as a TODO.

Thanks!

@alfg alfg added the enhancement New feature or request label Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants