Trouble with SendGrid Provider: Sender From Name

[thongbn]

Bug report

Describe the bug

From name for Strapi Sendgrid email provider.

Steps to reproduce the behavior

Change "from" in SendOptions from string to object for Sender Name in SendGrid Api will cause Error

strapi
      .plugin('email-designer')
      .service('email')
      .sendTemplatedEmail({
        to: sendTo,
        from: {
          email: process.env.DEFAULT_FROM_EMAIL,
          name: process.env.DEFAULT_FROM_EMAIL_NAME
        }
      }, {
        templateReferenceId: templateReferenceId
      }, {
        ...result,
        registeredDate: moment(result.createdAt).format("DD-MM-YYYY")
      })
      .catch(e => {
        console.error("Send email fail", e);
        strapi.log.error("Send mail error", e);
      });

It will got error in node_modules/strapi-plugin-email-designer/server/services/email.js

if (!isValidEmail.test(email)) throw new Error(`Invalid "${key}" email address with value "${email}"`);

I have to modify it to work with SendGrid email provider

let testAdress = address.email ? address.email : address;
if (!isValidEmail.test(testAdress)) throw new Error(`Invalid "${key}" email address with value "${address}"`);

Does have any another way to do it but not modify library code

System

• Node.js version: v16
• NPM version:
• Strapi version: 4.5.5
• Plugin version:
• Database: mariadb
• Operating system:

[github-actions]

Thank you!! This is your first issue on this repo

[creazy231]

Could you please try the following code:

strapi
      .plugin('email-designer')
      .service('email')
      .sendTemplatedEmail({
        to: sendTo,
+       from: `${process.env.DEFAULT_FROM_EMAIL_NAME} <${process.env.DEFAULT_FROM_EMAIL}>`,
-       from: {
-         email: process.env.DEFAULT_FROM_EMAIL,
-         name: process.env.DEFAULT_FROM_EMAIL_NAME
-       }
      }, {
        templateReferenceId: templateReferenceId
      }, {
        ...result,
        registeredDate: moment(result.createdAt).format("DD-MM-YYYY")
      })
      .catch(e => {
        console.error("Send email fail", e);
        strapi.log.error("Send mail error", e);
      });

This change should get the result you want without the need to change anything on package side

[thongbn]

@creazy231 thank you so much

[creazy231]

You're welcome 🙌