Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the performance issues when you scroll deep into the Photos Library #13

Open
alexwlchan opened this issue Jun 11, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@alexwlchan
Copy link
Owner

If you press ? to get a random unreviewed photo, the app massively slows down – I think it's pulling thousands of thumbnails into memory at once as it renders the intermediate LazyHStack. It feels like this is fixable, if I can stop it actually fetching the assets until they're shown on screen.

@alexwlchan alexwlchan added the bug Something isn't working label Jun 11, 2023
@alexwlchan
Copy link
Owner Author

I tried replacing the thumbnail images with static images, and I still see the latency – so it's not retrieving the image pixels that's the issue.

I wonder if the issue is inside PHAssetHStack – when you scroll, it's presumably making thousands of requests for a PHAsset from the Photos Library, even ones which aren't on screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant