Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback to 1.5.0-dev.4 #1401

Closed
helmutkaufmann opened this issue Aug 19, 2023 · 2 comments
Closed

Feedback to 1.5.0-dev.4 #1401

helmutkaufmann opened this issue Aug 19, 2023 · 2 comments

Comments

@helmutkaufmann
Copy link

Thanks Alex, for the great work. I have downloaded version 1.5.0-dev.4 . Here some feedback:

  • In config.php, GOOGLE_PRODUCT_NAME and GOOGLE_API_KEY are not defined and therefore the installation did not work.
  • The provider is receiving two confirmation mails, one with the chosen timezone and one with UTC
  • While email worked in 1.4.3, I had to add SMTP information to application/config/email.php - I assume this should also go into the config.php but application/config/email.php seems not set up to deal with constants defined in config.php.
  • If I enter a company email address, this address is also used as the sender address in the emails. It would be great if it were possible to add the full company name to the address field, so it is clear where the mail is coming from.
@alextselegidis
Copy link
Owner

Hello!

Thanks for the feedback!

In config.php, GOOGLE_PRODUCT_NAME and GOOGLE_API_KEY are not defined and therefore the installation did not work.

Those are not needed nor used in teh code, so the problem you are getting is probably in a different place and due to a different reason.

The provider is receiving two confirmation mails, one with the chosen timezone and one with UTC

This can only be the case if you use the same email as a customer and as a provider. By default providers are on UTC unless you change their timezone from the users page while creating them

While email worked in 1.4.3, I had to add SMTP information to application/config/email.php - I assume this should also go into the config.php but application/config/email.php seems not set up to deal with constants defined in config.php.

Could you please post the error here for further troubleshooting?

If I enter a company email address, this address is also used as the sender address in the emails. It would be great if it were possible to add the full company name to the address field, so it is clear where the mail is coming from.

I agree, in general the from address must also be part of the email configuration, so I will try to change that before the stable release

@alextselegidis
Copy link
Owner

Quick update on this one:

It is now possible to configure the from-address/name and the reply too as well, so this ticket can now be resolved

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants