Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better performance #28

Open
alexfikl opened this issue Sep 25, 2023 · 1 comment
Open

Better performance #28

alexfikl opened this issue Sep 25, 2023 · 1 comment
Labels
enhancement New feature or request performance Potential performance issues and improvements

Comments

@alexfikl
Copy link
Owner

alexfikl commented Sep 25, 2023

We will need to look into that at some point, since at the moment everything is implemented in the most naive way possible 馃槩. Some options worth thinking about.

Use np.convolve or similar for the convolutions

This should be fairly simple to implement. Is scipy.spatial.convolve faster?

Implement some kernels in Cython

Need to profile and see what's worth reimplementing. Is Rust better here?

Use numba or similar to JIT functions

Does this need any effort on our side or can numba just JIT from user code? At the very least we'd need to test it and see that

@alexfikl alexfikl added the enhancement New feature or request label Sep 25, 2023
@alexfikl
Copy link
Owner Author

Would need to set up some benchmarking to keep track of this!

@alexfikl alexfikl added enhancement New feature or request performance Potential performance issues and improvements and removed enhancement New feature or request labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Potential performance issues and improvements
Projects
None yet
Development

No branches or pull requests

1 participant