Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A need for a detailed documentation #7

Open
JefferyHus opened this issue Apr 10, 2017 · 3 comments
Open

A need for a detailed documentation #7

JefferyHus opened this issue Apr 10, 2017 · 3 comments

Comments

@JefferyHus
Copy link

Thanks first for this Circuit breaker module and the time you spent crafting such a beauty, but I would like to know if there will be any detailed documentation of this module soon or later, as I am using it inside an HttpModule class in async mode, I was lost because I had a timeout value for my Http request and dunno how much MS should I give to the breaker in the invocation nor the reset.
Also in your samples you have a code for aync use like this:

await circuitBreaker.ExecuteAsync(action);

I have tried this code but no such ExecuteAsync() method, that's why I ask for a more clarification of your work, thanks.

@alexandrnikitin
Copy link
Owner

Hi Jeffery,

Thanks for the kind words! The documentations is very much wanted. But I'm not sure I can find time in near future.
Regarding timeout, it depends, mostly on your dependency, its latency and SLA.

Regarding async, please make sure you use the latest, 0.4.0 atm. The support was added in the 0.2.2 version. You can find a working sample code in the repo

TryExecuteAsync(circuitBreaker, externalService.GetAsync).Wait();

@JefferyHus
Copy link
Author

JefferyHus commented Apr 10, 2017

Hi Alex,

Thanks for your reply 👍 , I would like to help you so I will be writing down some docs from time to time as I am using it in my work daily, I will make sure to report it if done, thanks lot 💯

@Caldas
Copy link

Caldas commented Mar 29, 2019

Hey @alexandrnikitin, a better documentation would be amazing 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants