Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken enums? #48

Open
roxaloxa opened this issue Sep 25, 2019 · 0 comments
Open

Broken enums? #48

roxaloxa opened this issue Sep 25, 2019 · 0 comments

Comments

@roxaloxa
Copy link

I'm poking at the enums for the first time and I currently have:

const Enums = require('the-traveler/build/type-definitions');
console.log(Enums);

and the output is:

{
  "App": {},
  "User": {},
  "Content": {},
  "Forum": {},
  "GroupV2": {},
  "Destiny2": {},
  "CommunityContent": {},
  "Trending": {},
  "Fireteam": {}
}

Naturally that seems wrong, so I dug into the package and it looks like there are interfaces.d.ts files (https://github.com/alexanderwe/the-traveler/blob/master/src/type-definitions/destiny2/interfaces.ts for example) that are full of definitions sitting next to empty interfaces.js files, which are the ones that actually get used. These are meant to be the generated files right? I'm not familiar with TypeScript but this is wrong yeah?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant