Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to skill.json doesnot reflect when pushed from git #474

Open
sarath opened this issue Jun 12, 2023 · 2 comments
Open

updates to skill.json doesnot reflect when pushed from git #474

sarath opened this issue Jun 12, 2023 · 2 comments
Labels

Comments

@sarath
Copy link

sarath commented Jun 12, 2023

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request 
[ ] Other... Please describe: 

I want to use git workflow with my hosted skill. I init-ed a hosted skill. as a test, made changes to skills.json. and push to master does not update the skill in distribution or interactive models

Expected Behavior

  1. when pushed to master values from skills.json should reflect in the ui and a new deployment should happen..
  2. (not certain about this) I should be able to push to "dev" and ui should see the new values, but it should not deploy.

Current Behavior

only updates to lambda code (js) is managed via git push to master. skill.json need to be manually update..

CLI Snapshot
If applicable, add screenshots to help explain your problem.

@sarath ➜ /tmp $ ask init --hosted-skill-id amzn1.ask.skill.xxxx ? Please type in your folder name for the skill project (alphanumeric): tskill

Project directory for xxx Status created at
/tmp/tskill

Lambda code for xxx Status created at
./lambda

Skill schema and interactionModels for xxx Status created at
./skill-package

xxx Status successfully initialized.

@sarath ➜ /tmp $ cd tskill/
@sarath ➜ /tmp/tskill (master) $ ls
README.md ask-resources.json lambda skill-package
@sarath ➜ /tmp/tskill (master) $ cat ask-resources.json
{
"askcliResourcesVersion": "2020-03-31",
"profiles": {
"default": {
"skillInfrastructure": {
"type": "@ask-cli/hosted-skill-deployer"
}
}
}
}@sarath ➜ /tmp/tskill (master) $ git checkout dev
branch 'dev' set up to track 'origin/dev'.
Switched to a new branch 'dev'
@sarath ➜ /tmp/tskill (dev) $ git status
On branch dev
Your branch is up to date with 'origin/dev'.

nothing to commit, working tree clean
@sarath ➜ /tmp/tskill (dev) $ cd skill-package/
@sarath ➜ /tmp/tskill/skill-package (dev) $ ls
assets interactionModels skill.json
@sarath ➜ /tmp/tskill/skill-package (dev) $ git ls
On branch dev
Your branch is up to date with 'origin/dev'.

Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git restore ..." to discard changes in working directory)
modified: skill.json

no changes added to commit (use "git add" and/or "git commit -a")
@sarath ➜ /tmp/tskill/skill-package (dev) $ git commit -am "keywods"
[dev 21947f9] keywods
1 file changed, 1 insertion(+), 1 deletion(-)
@sarath ➜ /tmp/tskill/skill-package (dev) $ git ls
On branch dev
Your branch is ahead of 'origin/dev' by 1 commit.
(use "git push" to publish your local commits)

nothing to commit, working tree clean
@sarath ➜ /tmp/tskill/skill-package (dev) $ git push
Alexa-Hosted Skills can be deployed by performing a git push to the Alexa-Hosted remote master branch. Please use following git commands for deploying hosted skills:
$ git checkout master
$ git merge dev
$ git push
error: failed to push some refs to 'https://git-codecommit.us-east-1.amazonaws.com/v1/repos/xxx'
@sarath ➜ /tmp/tskill/skill-package (dev) $ git remote -v
origin https://git-codecommit.us-east-1.amazonaws.com/v1/repos/xxx (fetch)
origin https://git-codecommit.us-east-1.amazonaws.com/v1/repos/xxx (push)
@sarath ➜ /tmp/tskill/skill-package (dev) $ git br
git: 'br' is not a git command. See 'git --help'.

The most similar commands are
branch
rbm
@sarath ➜ /tmp/tskill/skill-package (dev) $ git branch -a

  • dev
    master
    prod
    remotes/origin/dev
    remotes/origin/main
    remotes/origin/master
    remotes/origin/prod
    @sarath ➜ /tmp/tskill/skill-package (dev) $ git push origin dev
    Alexa-Hosted Skills can be deployed by performing a git push to the Alexa-Hosted remote master branch. Please use following git commands for deploying hosted skills:
    $ git checkout master
    $ git merge dev
    $ git push
    error: failed to push some refs to 'https://git-codecommit.us-east-1.amazonaws.com/v1/repos/xxxx'
    @sarath ➜ /tmp/tskill/skill-package (dev) $ git checkout master
    Switched to branch 'master'
    Your branch is up to date with 'origin/master'.
    @sarath ➜ /tmp/tskill/skill-package (master) $ git merge dev
    Updating 4009ef8..21947f9
    Fast-forward
    skill-package/skill.json | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)
    @sarath ➜ /tmp/tskill/skill-package (master) $ git push
    After the code pushed, please check the deployment status
    via Alexa Developer console:
    https://developer.amazon.com/alexa/console/ask/build/custom/amzn1.ask.skill.xxx/development/en_US
    Enumerating objects: 7, done.
    Counting objects: 100% (7/7), done.
    Delta compression using up to 2 threads
    Compressing objects: 100% (4/4), done.
    Writing objects: 100% (4/4), 392 bytes | 392.00 KiB/s, done.
    Total 4 (delta 3), reused 0 (delta 0), pack-reused 0
    remote: Validating objects: 100%
    To https://git-codecommit.us-east-1.amazonaws.com/v1/repos/xxx
    4009ef8..21947f9 master -> master

After these ^ my keywords are still not updated

Steps to Reproduce (for bugs)

Possible Solution

Your Environment and Context

  • ask-cli version: x.x.x
  • Operating System and version:
  • Node.js version used for development:
  • NPM version used for development:
@tydonelson tydonelson added the Bug label Jun 13, 2023
@tydonelson
Copy link
Contributor

Thanks for the detailed report @sarath ! We'll take a look :)

@sarath
Copy link
Author

sarath commented Jun 29, 2023

wanted to check if there has been any update. Please let me know if there is anything I can do to assist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants