Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce/Warn about Account Linking for Skills using the householdList API #448

Open
jschiefner opened this issue Mar 18, 2023 · 0 comments
Labels

Comments

@jschiefner
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request 
[ ] Other... Please describe: 

For Skills that use the householdList API it is now necessary to implement Account Linking (see https://amazon.developer.forums.answerhub.com/questions/247690/self-hosted-skill-no-longer-receiving-items-create.html)

When creating a new skill this is not enforced by the cli and no warning is issued whatsoever that account linking is required for this feature. Here is the necessary parts from my skill.json that make the list api work:

{
  "apis": {
      "householdList": {}
  },
  "events": {
    "endpoint": {
      "uri": "**************************",
      "sslCertificateType": "********"
    },
    "subscriptions": [
      {
        "eventName": "ITEMS_CREATED"
      },
      {
        "eventName": "ITEMS_UPDATED"
      },
      {
        "eventName": "ITEMS_DELETED"
      }
    ]
  },
  "permissions": [
    {
      "name": "alexa::household:lists:read"
    },
    {
      "name": "alexa::household:lists:write"
    }
  ],
}

Expected Behavior

When running ask deploy and the skill has no account linking implemented, the user should be warned that without account linking implemented, the list api and events will not work as expected.

Current Behavior

Running ask deploy works without any warnings related to account linking.

Steps to Reproduce (for bugs)

Create a new skill with ask new, add the requirements to the skill.json as specified above, try to receive events on the specified endpoints. It will not work because Account Linking is not implemented.

Possible Solution

Warn the user when deploying a skill that those features need account linking.

Your Environment and Context

  • ask-cli version: 2.28.0
  • Operating System and version: Mac OS 13.0.1
  • Node.js version used for development: v19.8.1
  • NPM version used for development: 9.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants