Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Migrate DynamoDbPersistenceAdapter to AWS SDK v3 and save 60Mb #696

Open
talkingnews opened this issue Oct 4, 2021 · 6 comments · May be fixed by #699
Open

Request: Migrate DynamoDbPersistenceAdapter to AWS SDK v3 and save 60Mb #696

talkingnews opened this issue Oct 4, 2021 · 6 comments · May be fixed by #699
Labels
dependencies Pull requests that update a dependency file investigating

Comments

@talkingnews
Copy link

Currently, DynamoDbPersistenceAdapter has a peer dependency of aws-sdk, which install 65Mb of stuff we don't need.

Whereas the current slimline v3 version of @aws-sdk/client-dynamodb is 4.97 Mb including dependencies.
https://www.npmjs.com/package/@aws-sdk/client-dynamodb

Is anyone working on a re-write, as this library is currently the difference between my skill package being 7Mb or 70Mb!

@sjcomstock67
Copy link

agree this is a pain point. Will try to bump it up on the priority list.

@sam-goodwin
Copy link

sam-goodwin commented Oct 27, 2021

We definitely want to get to this. @talkingnews just so I understand, are you using any type of bundling/tree-shaking like webpack or esbuild for your skill? This might be especially helpful if you are running in AWS Lambda since the SDKs are provided by the container - bundle the skill and mark aws-sdk as external - the bundler will not include any AWS SDK code in your bundle, leaving you with a tiny JS file you can run in your Lamdba.

I understand this might not always be the right solution, so we should still create a new version of the adapter which doesn't depend on the whole AWS SDK.

@sjcomstock67
Copy link

@doiron this was started by @sam-goodwin and there's a linked PR. We just need to finish it up. Will discuss during sprint planning.

@doiron doiron added dependencies Pull requests that update a dependency file investigating labels Apr 28, 2022
@rahulawl
Copy link
Contributor

Is this issue/feature-request still relevant?
We are working on prioritization of relevant issues and cleanup of rest. If we don’t hear back in 2 weeks, we will assume that the issue is not relevant and we will close it.

@seanfisher
Copy link

@rahulawl Yes, still relevant. See my comments in #697.

@doiron doiron removed their assignment Jan 13, 2023
@crackmac
Copy link

crackmac commented Mar 1, 2024

@rahulawl Yes, still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file investigating
Projects
None yet
8 participants