Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation schema not valid for cooking appliances #42

Open
digitalhoax opened this issue Feb 8, 2018 · 3 comments
Open

Validation schema not valid for cooking appliances #42

digitalhoax opened this issue Feb 8, 2018 · 3 comments

Comments

@digitalhoax
Copy link

digitalhoax commented Feb 8, 2018

The validation schema found in this repo is not valid for cooking appliances described in the API documentation. Please update the schema to reflect these new categories.

i.e. the example discovery response for a MICROWAVE device is invalid.

Furthermore, the documentation is completely inconsistent on this topic, e.g.
this documentation page lists supportedCookingModes whereas
the link above lists the same field as cookingModes

Is there any place more appropriate to list these mistakes, as there are quite a few in the documentation that should really be updated.

@simchery
Copy link

simchery commented Feb 9, 2018

Thanks for your feedback. I can comment on the docs issue. There was some last-minute renaming that resulted in the doc discrepancy you mentioned. This should be fixed now. An issue filed against the docs with a list of items to be fixed is fine. I have quite a large surface area to cover, and appreciate your input.

@mikemaas-amazon
Copy link
Contributor

An internal ticket was opened on 2018-02-08 to address the validation schema and is still being tracked. Will update when resolved or resolution path is known.

@zhanghj819
Copy link

@mikemaas-amazon @simchery
Now, I also encountered the same problem is the discovery response for a MICROWAVE device is invalid.

I need the following help:

  1. Validation schema MUST BE VALID for discovery response for cooking appliances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants