Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist: Provide "default" sport zone #65

Open
idealist1508 opened this issue Mar 23, 2021 · 1 comment
Open

Wishlist: Provide "default" sport zone #65

idealist1508 opened this issue Mar 23, 2021 · 1 comment

Comments

@idealist1508
Copy link
Contributor

At the moment, it is possible to set sports zones for running and cycling only. I suggest adding a default sport zone that will be used when no specific zone is defined.

@alex-hhh
Copy link
Owner

alex-hhh commented Apr 8, 2021

The database schema already allows specifying sport zones for any defined sport, see SPORT_ZONE and SPORT_ZONE_ITEM tables (see here), and adding new sports would simply mean updating the zone editor dialog to add the new sport. The rest of the code should pick up the sport zones for any sport.

Adding a "generic" sport zone is more complicated. In addition to updating the zone editor dialog, the code uses the V_SPORT_ZONE_FOR_SESSION SQL view to query which sport zones are valid for a session and this view would have to be updated to match generic sport zones when no specific zones match.

Alternatively, you can also update your database directly (or writing your own script to do it). This would be simpler if you want to add sport zones for a new, specific sport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants