[IPV6] Support setting multiple listeners and reported endpoints #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's normal enough to listen on an ipv4 endpoint and also an ipv6 endpoint. Extend the ability to specify an arbitrary IPEndPoint to instead allow specifying arbitrary IPEndPoints. By default the engine attempts to bind to IPAddress.Any and IPAddress.IPv6Any.
The 'ListenEndpoints' is what we configure the engine to listen for incoming connections on. The endpoint can be ipv4, ipv6, or both. 'ReportedListenEndPoints' is what we inform the tracker/dht of. This can differ from the bound IP address and port.
Don't rely on dictionary ordering too :)
Whenever we start/stop a listener we also want to map/unmap it's ports.
If the user configures an override which uses port '0', then that means the *real* listen port should be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to creating an IPV4 and IPV6 listener, bound to IPAddress.Any/IPV6Any, and port 0. Additionally, allow configuring an alternative reported IP address for both IPV4 and IPV6.
Partially fixes #588