Fix XSS issues in typeahead results

Alanaktion · Mar 12, 2022 · 00c6bbf · 00c6bbf
1 parent f40236c
commit 00c6bbf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/app/view/blocks/issue-list.html b/app/view/blocks/issue-list.html
@@ -85,7 +85,7 @@
                 },
                 templates: {
                     suggestion: function(element) {
-                        return '<div><span class="text-muted">#' + element.id + '</span> ' + element.text + '</div>';
+                        return '<div><span class="text-muted">#' + element.id + '</span> ' + new Option(element.text).innerHTML + '</div>';
                     }
                 }
             }).bind('typeahead:select', function() {

diff --git a/app/view/issues/edit.html b/app/view/issues/edit.html
@@ -55,7 +55,7 @@
         },
         templates: {
             suggestion: function(element) {
-                return '<div><span class="text-muted">#' + element.id + '</span> ' + element.text + '</div>';
+                return '<div><span class="text-muted">#' + element.id + '</span> ' + new Option(element.text).innerHTML + '</div>';
             }
         }
     });

diff --git a/app/view/issues/single.html b/app/view/issues/single.html
@@ -550,7 +550,7 @@ <h4 class="modal-title" id="modal-copy-label">{{ @dict.copy_issue }}</h4>
                 },
                 templates: {
                     suggestion: function(element) {
-                        return '<div><span class="text-muted">#' + element.id + '</span> ' + element.text + '</div>';
+                        return '<div><span class="text-muted">#' + element.id + '</span> ' + new Option(element.text).innerHTML + '</div>';
                     }
                 }
             });
@@ -706,7 +706,7 @@ <h4 class="modal-title" id="modal-copy-label">{{ @dict.copy_issue }}</h4>
         },
         templates: {
             suggestion: function(element) {
-                return '<div><span class="text-muted">#' + element.id + '</span> ' + element.text + '</div>';
+                return '<div><span class="text-muted">#' + element.id + '</span> ' + new Option(element.text).innerHTML + '</div>';
             }
         }
     });