Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent naming of traits and types #155

Open
sgreenbury opened this issue Nov 20, 2023 · 1 comment
Open

Consistent naming of traits and types #155

sgreenbury opened this issue Nov 20, 2023 · 1 comment

Comments

@sgreenbury
Copy link
Collaborator

Similar to refinement in #102. Some of traits and types implementing them could have more informative relationships. E.g. The trait TrustchainResolver and the struct HTTPTrustchainResolver could be considered as TrustchainResolve and TrustchainResolver (same applied to to verifier) (from @edchapman88).

This could be considered as part of a refactor during dev guide development.
@edchapman88
Copy link
Collaborator

Also consider refactor of "free factory function" trustchain_resolver to make it generic such that the LightClient version of the HTTPTrustchainResolver does not have to take a resolver as input in the method .with_endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgreenbury @edchapman88