Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools now requires a pyproject.toml file to specify dependencies #215

Open
edaub opened this issue Feb 10, 2022 · 0 comments
Open

setuptools now requires a pyproject.toml file to specify dependencies #215

edaub opened this issue Feb 10, 2022 · 0 comments

Comments

@edaub
Copy link
Collaborator

edaub commented Feb 10, 2022

setuptools (which we use in the setup.py file to configure the build) needs to have any dependencies for the build specified somewhere. This is done through a pyproject.toml file. The GPU build requires one additional dependency (numpy to get the include path for pybind11), so the build fails without a pyproject.toml file when building a distribution to upload to PyPI.

I have created a temporary local file on my computer that fixes this problem for the sake of uploading to PyPI. I have checked that the uploaded version installs correctly into a fresh virtual environment, but I want to be sure I understand what should be specified in the pyproject.toml file before committing one to the repo. Will be sure to sort this for merging version 0.7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant