Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing for GPU implementation on v0.6.0 branch #214

Open
nbarlowATI opened this issue Feb 10, 2022 · 0 comments
Open

Tests failing for GPU implementation on v0.6.0 branch #214

nbarlowATI opened this issue Feb 10, 2022 · 0 comments
Assignees

Comments

@nbarlowATI
Copy link
Member

There are currently five tests that fail when running pytest on a GPU-enabled machine. These are all numerical comparison failures and are all (to some extent) understood.

In test_GaussianProcess.py, the tests

  • test_GaussianProcessGPU_theta[0.0-1.0]
  • test_GaussianProcessGPU_theta[adaptive-0.0]
  • test_GaussianProcessGPU_predict
  • test_GaussianProcessGPU_predict_nugget
    fail because the way that the "expected" values are calculated directly from the python Kernel has not been updated to take account of the new ways that the parameters are transformed. The equivalent way of calculating the expected values for the CPU implementation now uses the design matrix, which is not easily available to the current GPU implementation.

In test_fitting.py, the test test_fit_GP_MAP_GPU fails because of a numerical comparison between the fitted theta values and some "expected" ones, which in the CPU equivalent, are just provided by a patched function. For the GPU/C++ implementation there is not an obvious python function to patch in this way.

It is expected that these tests will be updated/fixed in #211.

@nbarlowATI nbarlowATI self-assigned this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant