Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MICEDesign tests #193

Open
edaub opened this issue Sep 20, 2021 · 0 comments
Open

Fix MICEDesign tests #193

edaub opened this issue Sep 20, 2021 · 0 comments

Comments

@edaub
Copy link
Collaborator

edaub commented Sep 20, 2021

The changes to the GP interface that are currently being implemented on a branch break some of the MICE tests. This is because of changes to the default GP that is initialized automatically by the MICE class. This will eventually be fixed to conform to the new interface, at which point the tests should be updated/corrected.

However, the lack of tests and interface changes should not change the correctness of the implementation, just the particular results that are produced from running a model. Thus, the code should remain usable and results can be trusted until this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant