Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic warnings raised in dsh config template #1838

Open
JimMadge opened this issue Apr 26, 2024 · 0 comments
Open

Pydantic warnings raised in dsh config template #1838

JimMadge opened this issue Apr 26, 2024 · 0 comments
Labels
bug Problem when deploying a Data Safe Haven.

Comments

@JimMadge
Copy link
Member

When running dsh config template Pydantic raises warnings as some "help strings" are not expected types,

❯ dsh config template > config.yaml
/Users/jmadge/Library/Application Support/hatch/env/virtual/data-safe-haven/R3_ZGVTw/data-safe-haven/lib/python3.12/site-packages/pydantic/main.py:328: UserWarning: Pydantic serializer warnings:
  Expected `enum` but got `str` - serialized value may not be as expected
  Expected `bool` but got `str` - serialized value may not be as expected
  Expected `bool` but got `str` - serialized value may not be as expected
  return self.__pydantic_serializer__.to_python(

We could,

  • suppress the warnings
  • use the expected types then add comments another way
@JimMadge JimMadge added the bug Problem when deploying a Data Safe Haven. label Apr 26, 2024
@JimMadge JimMadge added this to the Release 5.0.0rc2 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem when deploying a Data Safe Haven.
Projects
None yet
Development

No branches or pull requests

1 participant