Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when application secret already exists #1814

Open
5 tasks done
jemrobinson opened this issue Apr 16, 2024 · 0 comments
Open
5 tasks done

Error when application secret already exists #1814

jemrobinson opened this issue Apr 16, 2024 · 0 comments
Labels
bug Problem when deploying a Data Safe Haven.
Milestone

Comments

@jemrobinson
Copy link
Member

✅ Checklist

  • I have searched open and closed issues for duplicates.
  • This is a problem observed when deploying a Data Safe Haven.
  • I can reproduce this with the latest version.
  • I have read through the documentation.
  • This isn't an open-ended question (open a discussion if it is).

💻 System information

  • Operating System: macOS
  • Data Safe Haven version: develop @ 8e76a2f

🚫 Describe the problem

When trying to deploy an SRE that re-uses an old AzureAD application, a new secret needs to be created with an existing name. This fails with "secret already exists".

We should either

  • tear down the AzureAD application when the SRE is torn down
  • overwrite the existing secret

🌳 Log messages

Relevant log messages
2024-04-16 11:08:44 [   ERROR]     error: Exception calling application: Failed to create application sre-apple-apricot in AzureAD.                                                                                                                    cli.py:99
2024-04-16 11:08:44 [   ERROR]     Could not create application secret 'Apricot Authentication Secret'.                                                                                                                                                              cli.py:99
2024-04-16 11:08:44 [   ERROR]     Secret 'Apricot Authentication Secret' already exists in application 'sre-apple-apricot'.

♻️ To reproduce

Deploy, teardown and then redeploy an SRE.

@jemrobinson jemrobinson added the bug Problem when deploying a Data Safe Haven. label Apr 16, 2024
@jemrobinson jemrobinson added this to the Release 5.0.0rc2 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem when deploying a Data Safe Haven.
Projects
None yet
Development

No branches or pull requests

2 participants