Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage whether to add tests and refactor #130

Open
7 tasks
griff-rees opened this issue Feb 5, 2024 · 0 comments
Open
7 tasks

Triage whether to add tests and refactor #130

griff-rees opened this issue Feb 5, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request python python code

Comments

@griff-rees
Copy link
Collaborator

griff-rees commented Feb 5, 2024

This is a meta ticket to cover cases of refactoring that could ease automating of testing. These may not be viable in the time we have, but to at least keep track of these decisions for the near term versus the long term.

  • python/resampling/resampling_hads.py
    • check `enforce_date_dropping.py
    • refactor python/resampling/check_calendar.py, which looks like a test as mentioned in HADs 360 day calendar conversion #32 but isn't incorporated in the pytest configuration. It does require mounting an external drive but doesn't import or call any code from python/resampling/resampling_hads.py. Shifting an equivalent of this to the tests/ folder may be helpful
    • Whether to refactor with tests
  • python/debiasing/pre_processing.py
    • Checking the preprocess_data function may require refactoring
    • Whether to refactor with tests
@griff-rees griff-rees changed the title Python refactor for testing Add tests as we refactor Feb 5, 2024
@griff-rees griff-rees changed the title Add tests as we refactor Triage whether to add tests and refactor Feb 5, 2024
@griff-rees griff-rees added enhancement New feature or request python python code labels Feb 5, 2024
@griff-rees griff-rees self-assigned this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python python code
Projects
None yet
Development

No branches or pull requests

1 participant