Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including multiple PyTorch models in compare() #190

Open
mastoffel opened this issue Feb 27, 2024 · 1 comment
Open

Including multiple PyTorch models in compare() #190

mastoffel opened this issue Feb 27, 2024 · 1 comment
Assignees
Labels

Comments

@mastoffel
Copy link
Collaborator

In the MODEL_REGISTRY under autoemulate.emulators.__init__py, we are adding models like this:

MODEL_REGISTRY = {
 "GaussianProcessSk": GaussianProcessSk(),
 "SupportVectorMachines": SupportVectorMachines(),
"NeuralNetTorch": NeuralNetTorch(module="mlp")
}

A second neural network would be added like this:

MODEL_REGISTRY = {
 "GaussianProcessSk": GaussianProcessSk(),
 "SupportVectorMachines": SupportVectorMachines(),
"NeuralNetTorch": NeuralNetTorch(module="mlp")
"NeuralNetTorch": NeuralNetTorch(module="rbf")
}

Which currently fails. The reason is that there are a range of checks which use get_model_name(), a function that accesses the class name. So that function needs to be changed and different PyTorch networks renamed in the MODEL_REGISTRY. This means that a few methods/functions will likely need an additional input which is a dict mapping model names. See also #175

@bryanlimy
Copy link
Member

This is solved in #196 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants