Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the settings configurable #52

Open
ZvonimirMatic opened this issue Sep 13, 2023 · 1 comment
Open

Making the settings configurable #52

ZvonimirMatic opened this issue Sep 13, 2023 · 1 comment

Comments

@ZvonimirMatic
Copy link

I think the settings could be more configurable. I don't see the reason for only one constructor with required parameters. In my opinion most of the properties should be able to be set publicly with some default values. This would allow for appsettings.json configuration. Also it would be very useful to be able to control certain parameters such as SqliteDbPath.

The interface ISejilSettings seems unnecessary.

If you want I can help you with the changes, but I would like your opinion first.

Other than that, it' a great library you've built!

@ZvonimirMatic
Copy link
Author

ZvonimirMatic commented Sep 13, 2023

I started working on it, but I can't build the Client application. Tried npm install - got an error so tried npm install --force, but then running npm run build breaks with th following error:

> sejil-ui@0.1.0 build
> react-app-rewired build

node:internal/modules/cjs/loader:535
      throw e;
      ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/tokenize' is not defined by "exports" in C:\projects\Sejil\src\Sejil.Client\node_modules\postcss-safe-parser\node_modules\postcss\package.json
    at new NodeError (node:internal/errors:393:5)
    at throwExportsNotFound (node:internal/modules/esm/resolve:358:9)
    at packageExportsResolve (node:internal/modules/esm/resolve:668:3)
    at resolveExports (node:internal/modules/cjs/loader:529:36)
    at Module._findPath (node:internal/modules/cjs/loader:569:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:981:27)
    at Module._load (node:internal/modules/cjs/loader:841:27)
    at Module.require (node:internal/modules/cjs/loader:1061:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (C:\projects\Sejil\src\Sejil.Client\node_modules\postcss-safe-parser\lib\safe-parser.js:1:17) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

Node.js v18.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant