-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why v4 exists if it's based on react navigation? #2001
Comments
Good question. I'm going to submit Lighting Talk about it for ReactiveConf: Will post it soon. |
My talk proposal |
I started with React Navigation and had lot's of issues getting it up and running mostly due to lack of good documentation for complex examples and use cases. I also had different bugs. With all that I also got the very little support I even sent feedback about and question why FB made React Navigation the official router lib, I don't think it should be. I see React Native Router as a wrapper over the React Navigation API making it much easier to use and better support. |
@Maxwell2022 this should help when comparing the two of them...
|
It was not just for me but for everyone. This should be added in the README. Would it make more sense to concentrate efforts on improving react-navigation (core or documentation)? I've used RNRF in previous projects and I also faced frustration because of the docs not being up to date or information being hard to find. I think it's a common problem for every complex library, documentation is probably the harder part to maintain. |
@Maxwell2022 Improving react-navigation instead?? Maybe you are joking, really. Just for experiment I submitted really useful PR react-navigation/react-navigation#1999, it took 2 weeks (!) to complete review, I fixed all (!) suggestions from reviewers and after that one from authors said that my PR is not needed because he worked on 'refactoring' of navbar API! Huh, probably new breaking changes... And check other PRs, a lot very useful PRs are not merged for MONTHS. |
And yes, docs are harder part to maintain, especially for open source projects. The problem that most community prefer just to use open source without any contribution. |
@aksonov if ReactNavigation is hard to improve (because of slow PR merge and all) isn't that going to be a problem for v4? |
Many problems like navbar customization (like setting right/left navbar images), action processing (like added missed popTo) could be solved by RNRF. Anyway, v3 is based on obsolete react-native-experimental-navigation, so I don't see any better alternative. |
Well I'm implementing the react-native-router-flux on a project right now and I'm keeping v3 for now. I tried V4 and it broke the whole thing. |
Here are my 2 cents.
Since I switched to React Navigation, yes there's quite a lot of thing i'm not using yet, and yes it's really a lot of abstraction which complicates things a lot. But so far the only problem I have with it is how painful it is to implement a login system disabling user from going back. With a bit of hacky code it makes through but still, that's not normal. Let's keep in mind that it's young and driven around specific needs. I believe it will get better. Not intending to spit on your work, guys. RNRF is really an awesome choice, back then it was the best i've found, and many articles on google support it. But I really got frustrated by the problems above. And React Navigation solved them enough to me. |
Totally agree with @Rewieer |
Regarding slow transitions: I ask because haven't had any problems with transitions. The only time I noticed a slow transition was when I had some buggy code in my react native projects. Something sounds off though. Sorry for going off topic. |
@typeslower so far it was working fine on emulator but was painfully slow on phone. |
I would say sorry because I am still in the opposite of V4, as I think V3 still the best.
By the way, @Rewieer, I have seen the same issue, and I make a bit change to achieve better transition among scenes in navigation, delayed the Animiated.timing in DefaultReducer, to render and finish the scene will go back and forth between javascript core and native code, if they both start same time, this could be a interference. Of cause, to keep major content view show-up only after it finished in Interaction Manager. Anyway, I still very supportive for the new version, but for now stick to the V3 instead. As I really like that consistency among different device. |
It really comes down to how fast you need to deliver your work. I work in an marketing agency environment and RNRF was invaluable to us. There was no time to master the complexity of React Navigation and so we decided to go through with RNRF since day 1. I've had a little bit of pain with the documentation, but nevertheless worked my way through it and delivered apps that are currently running at 60FPS on most devices. |
@rodperottoni please tell us more about what kind of complexity you are talking about when you refer to React Navigation, just out of curiosity. |
@Rewieer gladly.
|
Notice: this issue has been closed because it has been inactive for more than 30 days. |
I think it would make sense to explain what this lib is offering that reactnavigation is not.
The text was updated successfully, but these errors were encountered: