Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should it be "int align = kAlign * aux_size;" => "int align = kAlign;" for ftrl in ffm_score.cc line 57 #349

Open
jackyhawk opened this issue Oct 14, 2020 · 2 comments

Comments

@jackyhawk
Copy link

should it be "int align = kAlign * aux_size;" => "int align = kAlign;" for ftrl in ffm_score.cc line 57

as for "for (index_t d = 0; d < align0; d += align) {" would skip some part and not update(or calculate)

@jackyhawk
Copy link
Author

for sse, it would be align=4 for sse;
and if it works as xlearn,
"int align = kAlign * aux_size;"

it would skip some part if k is larger than 4

@jackyhawk
Copy link
Author

any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant