Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashed indent guides incosistent with tab level #93

Open
pesader opened this issue Aug 13, 2021 · 0 comments
Open

Dashed indent guides incosistent with tab level #93

pesader opened this issue Aug 13, 2021 · 0 comments

Comments

@pesader
Copy link

pesader commented Aug 13, 2021

Describe the bug
The dashed indent guides are the same for differently indented tabs, i.e. tabs on different "levels".

To Reproduce
Steps to reproduce the behavior:

  1. Select one of Flying Fox's custom css configurations for Tree Style Tabs. I checked this behavior happens on both custom.css and custom-hover.css.
  2. Open a link in a new tab, so that you have one level of indentation.
  3. On that new tab, open another link in another new tab. You should now have two levels of indentation.
  4. Notice how both show a dashed line at the same level, which is a bit confusing.

Screenshots
image

Firefox Version
91.0

Additional Information
I tried tweaking the css a little bit, but I'm not much of an expert 😅. I have a hunch that using the data-level variable to set the margin-left field of tab-item might solve this.

In any case, here's the best pseudo-css I could come up with:

tab-item:not([data-level="0"]):not(.pinned) {
    ...
    margin-left: calc(data-level * 7px);
    ...
}

And, of course, thanks for developing FlyingFox! It made my productivity skyrocket on my many online classes 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant