Skip to content
This repository has been archived by the owner on Feb 3, 2020. It is now read-only.

Device using Traditional Chinese in Taiwan (zh-Hant-TW) returning empty string #99

Open
samwize opened this issue Jan 25, 2018 · 1 comment

Comments

@samwize
Copy link

samwize commented Jan 25, 2018

Detailed Description

getLanguageBundle is returning nil. Strangely, locale.identifier is returning zh-TW, without the "Hant".

The 2nd part of getLanguageBundle therefore only get the language code as zh.

Since now the bundle only has zh-Hant, no localized string is found.

Context

Localization does not work for Taiwan app users.

Possible Implementation

I believe another fallback using Bundle to load will work.

Your Environment

  • Version used: 0.7
  • Operating System and version: 11.2
  • Link to your project: -
@samwize samwize changed the title Device using Traditional Chinese in Taiwan (zh-Hant-TW) region returning empty string Device using Traditional Chinese in Taiwan (zh-Hant-TW) returning empty string Jan 25, 2018
@samwize
Copy link
Author

samwize commented Jan 25, 2018

I have fixed in my fork here: samwize@41e2b52

What do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant