Add support for logback-access v2 #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croudet
force-pushed
the
logback-access-v2
branch
from
104722c
to
20fd5e5
Compare
DarkAtra
reviewed
Apr 26, 2024
| /** | ||
| * Request wrapper that implements Servlet API. | ||
| */ | ||
| class RequestWrapper(private val request: Request) : HttpServletRequest, WrappedHttpRequest { |
There was a problem hiding this comment.
i'm not a maintainer of this project but It might be a better idea to ask the logback people to make their RequestWrapper constuctor public.
akkinoc
reviewed
May 20, 2024
Comment on lines
+130
to
+143
| <groupId>ch.qos.logback.access</groupId> | ||
| <artifactId>common</artifactId> | ||
| <version>2.0.1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ch.qos.logback.access</groupId> | ||
| <artifactId>tomcat</artifactId> | ||
| <version>2.0.1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ch.qos.logback.access</groupId> | ||
| <artifactId>jetty12</artifactId> | ||
| <version>2.0.1</version> | ||
| </dependency> |
There was a problem hiding this comment.
Is the primary purpose of this pull request to support Jetty 12? Or is it to support logback-access v2?
If primary purpose is to support Jetty 12:
Is it possible to use the version of "ch.qos.logback.access" defined in spring-boot-dependencies (without specifying the version)? Basically because I want to follow the versions defined in spring-boot-dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes