Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert classes to interfaces #19

Open
esodan opened this issue Jan 11, 2018 · 1 comment
Open

Convert classes to interfaces #19

esodan opened this issue Jan 11, 2018 · 1 comment

Comments

@esodan
Copy link
Contributor

esodan commented Jan 11, 2018

Currently all implementations are classes, but this will be a problem for external implementations of Items and Shapes, so I think they should be converted to Interfaces and actual classes convert (by renaming) them to default implementations.
Example:
public interface GtkCanvas.Item : Object, Actor {
public signal void selected (Clutter.ModifierType modifiers);
(.. convert to abstract or virtual methods)
}
/* Current GtkCanvas.CanvasItem could be renamed to GtkCanvas.GcItem */

Why?

Because I'm implementing GSVGtk with objects to draw SVG images and shapes, so libgtkcanvas can add classes derived from GSVGtk ones and implementing libgtkcanvas interfaces, so it will get SVG shapes for free.

@Philip-Scott
Copy link
Member

I made a channel on slack so we could discuss this :)

If you could help us out with implementing your GSVGtk library so we could render SVGs that would be sweet! That's one of the mayor blockers before we can get an MVP of the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants