force_claim_period_start can put the contract in an invalid state

[andreiashu]

Description

force_claim_period_start is an owner_only operated function that allows the owner of the contract to move the stage into Claim:

review-elrond-launchpad-2021-10/code/launchpad/src/launchpad.rs

Lines 44 to 50 in a32fe0b

	#[only_owner]
	#[endpoint(forceClaimPeriodStart)]
	fn force_claim_period_start(&self) -> SCResult<()> {
	let total_winning_tickets = self.nr_winning_tickets().get();
	self.total_confirmed_tickets().set(&total_winning_tickets);
	Ok(())

The issue is that this function should fail when the owner, mistakenly, calls it and creates a stage transition that is erroneous.

For example, when in any stage before ConfirmTickets, this function should fail: moving to Claim stage without allowing users to confirm their tickets does not make sense.

Recommendation

The function should check if the stage transition is a valid one before allowing an owner to perform it.