Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exq.Stats.Server and Exq.Stats.Server crash in case of unexpected Redis closed connection #393

Open
aby2503 opened this issue Oct 28, 2019 · 0 comments

Comments

@aby2503
Copy link

aby2503 commented Oct 28, 2019

In case of unexpected redis exception, GenServer crashes without further restart.
First type of error
(MatchError) no match of right hand side value: {:error, %Redix.ConnectionError{reason: :closed}} (exq) lib/exq/redis/connection.ex:88: Exq.Redis.Connection.lrem!/4 (exq) lib/exq/middleware/job.ex:40: Exq.Middleware.Job.remove_job_from_backup/1 (exq) lib/exq/middleware/pipeline.ex:82: Exq.Middleware.Pipeline.chain/2 (exq) lib/exq/worker/server.ex:133: Exq.Worker.Server.handle_cast/2 (stdlib) gen_server.erl:637: :gen_server.try_dispatch/4 (stdlib) gen_server.erl:711: :gen_server.handle_msg/6 (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3 Last message: {:"$gen_cast", {:done, :ok}}

Second type of error
[error] GenServer Exq.Stats terminating (Redix.ConnectionError) the connection to Redis is closed (redix) lib/redix.ex:461: Redix.pipeline!/3 (exq) lib/exq/redis/connection.ex:171: Exq.Redis.Connection.qp!/2 (exq) lib/exq/stats/server.ex:137: Exq.Stats.Server.process_queue/4 (exq) lib/exq/stats/server.ex:126: Exq.Stats.Server.terminate/2 (stdlib) gen_server.erl:673: :gen_server.try_terminate/3 (stdlib) gen_server.erl:858: :gen_server.terminate/10 (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3 Last message: :flush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant