Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

IE11の場合、チケット作成画面でテンプレ選択の欄が表示されない / Plugin 1.x and latest does not support IE11. #310

Open
y503unavailable opened this issue Jan 26, 2020 · 11 comments

Comments

@y503unavailable
Copy link

This is a template to report bug related to redmine issue templates plugin.
You can fill in any format, free style in case report features or questions.

Summary

IE11の場合、チケット作成画面でテンプレ選択の欄が表示されない。

Description

IE11の場合、チケット作成画面でテンプレ選択の欄が表示されない。

Chrome-adminでログイン/チケット作成画面/トラッカー選択/テンプレ選択-OK
IE11 -adminでログイン/チケット作成画面/トラッカー選択/テンプレ選択の欄が表示されない。
(トラッカーの直下が題名になる)

IE11の場合、テンプレの選択肢が表示されないこと以外はエラー表示無し

但し、IE11の開発者ツール/コンソールで下記エラーが発生している。

issue_template.js (22.21) 構文エラーです
clearValue: (id) => {
(ISSUE_TEMPLATE.prototype = { の後)

New(345,83): document.getElementById('issue_template').addEventListener('change', (event) => {
(templateNS.set_pulldown(tracker)の後)

Environment

Server

Issue Template Plugin 1.0.0
Redmine trunk(4.1.0+修正有 )
Ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-linux]
CentOS 7.7
Database MariaDB 10.4.11
Rails Env: Production

Client

Windows10-1909,IE11(更新バージョン:11.0.165(KB4530677))
Chrome 79.0.3945.117

These informations are greatly helpful to support quickly.
You can get these informations from Redmine's information page.
(E.g. http://example.com/admin/info)

  • Redmine version
  • Installed plugins
  • Ruby version
  • OS Platform
  • Database (MariaDB, MySQL, PostgreSQL) and its version
  • Rails Env

Visual Proof / Screenshot

When reporting an application error, post the error stack trace that
you should find in the log file (eg. log/production.log).

Screen shot would be also helpful.

Expected Results

Actual Results

Workaround

Please let me know if you have any workaround.

@github-actions
Copy link

Thank you for contributing to Redmine Issue Templates plugin!' first issue

@akiko-pusu
Copy link
Owner

Hi. This is because Issue Template version 1.0.0 is using ES6.
And this release does not support compatibility now.
Maybe I could transpile/compile ES6 JavaScript, but I don't know if there is really demand.

@y503unavailable
Copy link
Author

Thank you for checking.

I understand that the ES6-IE11 compatibility problem is the cause.

How many Redmine users are actually available only in IE11?
I do not know. 🤔

@akiko-pusu
Copy link
Owner

How many Redmine users are actually available only in IE11?

I won't respond until there really is demand. Especially, if users can use other browsers.

@vividtone
Copy link
Collaborator

FYI: I am running Redmine for hundreds of corporate customers. About 20% of users access Redmine with Internet Explorer.

I have to stay on version 0.3.7 for the time being, but I don't think the plugin should support Internet Explorer because the browser is expected to disappear in the near future.

@akiko-pusu
Copy link
Owner

@vividtone Thanks for your comments.

@y503unavailable
This report is very helpful, especially for those who installed the latest version of this plugin and don't work with IE11 or early version.
So, I pinned this issue and keep open for a while.

And I hope to spent my limited time to evaluate this new feature is really effective or not, and to improve the UI more friendly.

To think about polyfill and compatibility will be issues after I confirm this feature is valuable.

akiko-pusu added a commit that referenced this issue Jan 28, 2020
akiko-pusu added a commit that referenced this issue Jan 28, 2020
@janmashat
Copy link

Hi, what's the plan and timeline for resolving this issue? I'm asking because we would like to use this plugin, but some of our customers are on IE11 (corporate policy) so this is currently a blocker. How I see 0.3.7 is recommended for IE11 support, but will that version be supported moving forward? I assume it's better to postpone installing this plugin while the issue isn't resolved in 1.x?

@akiko-pusu
Copy link
Owner

akiko-pusu commented Apr 10, 2020

Hi, @janmashat
Sorry for my delayed reply and thank you for telling me your situation.

In Japan, there are still many IE11 users.
Therefore, I will keep and maintain version 0.3.x for a while, for at least a year or two.

My plugin 1.x is using not only Vue.js but also HTML5, JavaScript es6, and some API.
It's pretty hard for me to write some polyfill code.

https://babeljs.io/docs/en/babel-polyfill may help to implement compatibility between IE11 and modern browsers, but I can't say for sure.

@akiko-pusu akiko-pusu changed the title IE11の場合、チケット作成画面でテンプレ選択の欄が表示されない。 IE11の場合、チケット作成画面でテンプレ選択の欄が表示されない / Plugin 1.x and latest does not support IE11. Apr 10, 2020
@truumahn
Copy link

Do I understand correctly that this issue doesn't break IE, just doesn't work with it? In that case I'd think the plugin can be used with mixed browsers from the user side, IE simply has less features. Is it possible to do an early escape of the JavaScript code if it's being run in IE?

https://stackoverflow.com/a/21712356

@akiko-pusu
Copy link
Owner

akiko-pusu commented Jul 14, 2020

Hi, @truumahn
If you and your staffs still use IE11, please not to update the version 1.0 or later.
On the 0.3-stable branch, IE11 is available.
I'll keep the maintenance for this 0.3-stable branch for a while, but no additional feature would be applied.

this issue doesn't break IE, just doesn't work with it?

If you install the latest version (including 1.x), other browsers such as Chrome, Safari, Firefox and Edge may work without any problem.

IE simply has less features

No. IE11 does not work properly with the latest version (1.0 or later).
If you try to apply an issue template while creating a new issue, you will get a JavaScript error.

The latest version of this plugin is using "fetch" API.

And more two parts.

Of course, you can replace this fetch API by using XMLHttpRequest or $.ajax.

Exp. https://github.com/akiko-pusu/redmine_issue_templates/blob/0.3-stable/assets/javascripts/issue_templates.js#L68

Now I don't have much time and motivation to write the polyfill code only for IE11.

@vividtone
Copy link
Collaborator

According to the following page by Microsoft, even Microsoft 365 is going to drop support for Internet Explorer on August 17, 2021. I think people should not use IE11 any longer and developers don't have to spend their time on such an abandoned web browser.

Microsoft 365 apps say farewell to Internet Explorer 11 and Windows 10 sunsets Microsoft Edge Legacy - Microsoft Tech Community - 1591666

@akiko-pusu akiko-pusu unpinned this issue Jan 22, 2021
@akiko-pusu akiko-pusu pinned this issue Jan 22, 2021
@akiko-pusu akiko-pusu unpinned this issue Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants