Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflows #144

Open
2 tasks
ygrishajev opened this issue Apr 2, 2024 · 0 comments
Open
2 tasks

Update CI workflows #144

ygrishajev opened this issue Apr 2, 2024 · 0 comments
Labels
enhancement New feature or request P3 priority 3 feature/ enhancement

Comments

@ygrishajev
Copy link
Collaborator

ygrishajev commented Apr 2, 2024

Currently 2 workflows are happening in parallel on merge to main:

  1. tests
  2. release
    image

which doesn't make much sense as release should depend on tests to be cancelled if ones fail. There are ways to do it a more logical fashion. Some of them are:

  • protect master and run test only on feature branches. So that in master it only releases. This one has an issue that tests wouldn't run if a hot-fix is required directly in main
  • run release when tests are green. this one is more safe but would double run tests for the same commit if merge is done with a rebase.

It looks like option 2 would be more consistent though.
Some optimisation can be done there by finding/creating a custom action to skip tests if those are already run against head_commit.

Tasks:

  • Make sure release does depend on tests
  • Skip running tests if already done for current head_commit
@ygrishajev ygrishajev added the enhancement New feature or request label Apr 17, 2024
@anilmurty anilmurty added the P3 priority 3 feature/ enhancement label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 priority 3 feature/ enhancement
Projects
Status: Backlog (not prioritized)
Development

No branches or pull requests

2 participants