Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Akashjs validation #133

Closed
baktun14 opened this issue Mar 19, 2024 · 4 comments
Closed

Improve Akashjs validation #133

baktun14 opened this issue Mar 19, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request P2 priority 2 feature/ enhancement

Comments

@baktun14
Copy link
Collaborator

baktun14 commented Mar 19, 2024

  • Move custom validation done in Cloudmos for the SDL parsing to Akashjs
  • Properly show the error message in Cloudmos when the validation throws in akashjs
  • Improve the logic between between Cloudmos and the SDL parsing from Akashjs
@ygrishajev
Copy link
Collaborator

@baktun14 why moving it to akashjs? is it needed anywhere else besides cloudmos?

@baktun14
Copy link
Collaborator Author

Initially the sdl parsing was done in Cloudmos for Cloudmos and akashjs implemented the same logic so we migrated to use akashjs's implementation. However, there's some validation done to make sure the SDL is valid that we implemented in Cloudmos that was partially implemented in akashjs.

So now it's just a matter of moving all the validation logic to the same place, in AkashJS.

For context, we implemented the validation based on the validation done on the nodes in go code. So we can validate the SDL dynamically in the client without getting an error along the way when creating the transactions to create a deployment or to send a manifest.

@baktun14
Copy link
Collaborator Author

cc @troian I know you mentionned about moving the SDL parsing logic to akash-api. Let us know if you have something to add about the validation of the SDLs.

@ygrishajev ygrishajev self-assigned this Apr 19, 2024
@baktun14 baktun14 added enhancement New feature or request P2 priority 2 feature/ enhancement labels Apr 30, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 6, 2024
ygrishajev added a commit that referenced this issue May 6, 2024
ygrishajev added a commit that referenced this issue May 6, 2024
ygrishajev added a commit that referenced this issue May 6, 2024
ygrishajev added a commit that referenced this issue May 6, 2024
ygrishajev added a commit that referenced this issue May 7, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 7, 2024
ygrishajev added a commit that referenced this issue May 7, 2024
ygrishajev added a commit that referenced this issue May 7, 2024
ygrishajev added a commit that referenced this issue May 7, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 9, 2024
also improve basic yml templating with default values

refs akash-network/cloudmos#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 9, 2024
also improve basic yml templating with default values

refs akash-network/cloudmos#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 9, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
also improve basic yml templating with default values

refs akash-network/cloudmos#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
also improve basic yml templating with default values

refs akash-network/cloudmos#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
github-actions bot pushed a commit to akash-network/akashjs that referenced this issue May 10, 2024
## [0.8.0](v0.7.1...v0.8.0) (2024-05-10)

### Features

* **api:** move deployment relations and ip lease validation from cloudmos ([a7eb767](a7eb767)), closes [akash-network/cloudmos#133](akash-network/cloudmos#133)
* **sdl:** implement service image credentials ([06a73e8](06a73e8)), closes [akash-network/cloudmos#168](akash-network/cloudmos#168)
* **sdl:** move denom validation from cloudmos to sdl ([#133](https://github.com/akash-network/akashjs/issues/133)) ([1b5362f](1b5362f))
* **sdl:** move endpoint validation from cloudmos ([#133](https://github.com/akash-network/akashjs/issues/133)) ([0b770ec](0b770ec))
ygrishajev added a commit that referenced this issue May 10, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 13, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 13, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 13, 2024
github-actions bot pushed a commit to akash-network/akashjs that referenced this issue May 13, 2024
## [0.8.1](v0.8.0...v0.8.1) (2024-05-13)

### Bug Fixes

* **sdl:** fallback credentials email to an empty string ([4657dc5](4657dc5)), closes [akash-network/cloudmos#133](akash-network/cloudmos#133)
ygrishajev added a commit that referenced this issue May 13, 2024
to acquire credentials email default value assignment

refs #133
ygrishajev added a commit that referenced this issue May 13, 2024
ygrishajev added a commit that referenced this issue May 13, 2024
to acquire credentials email default value assignment

refs #133
@ygrishajev
Copy link
Collaborator

This is half done and merged. Had to switch to some more prior issues. Currently in progress

ygrishajev added a commit to akash-network/akashjs that referenced this issue May 16, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 16, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 16, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 16, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 17, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 17, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 17, 2024
github-actions bot pushed a commit to akash-network/akashjs that referenced this issue May 17, 2024
## [0.10.0](v0.9.2...v0.10.0) (2024-05-17)

### Features

* **sdl:** add storage and gpu validation ([b125da7](b125da7)), closes [akash-network/cloudmos#133](akash-network/cloudmos#133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 priority 2 feature/ enhancement
Projects
Status: Released (in Prod)
Development

No branches or pull requests

2 participants