Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing proposer in proposal endpoint #132

Open
Redm4x opened this issue Mar 19, 2024 · 1 comment
Open

Fix missing proposer in proposal endpoint #132

Redm4x opened this issue Mar 19, 2024 · 1 comment
Labels
bug Something isn't working sev3 severity 3 bug

Comments

@Redm4x
Copy link
Collaborator

Redm4x commented Mar 19, 2024

The proposer is never returned in the /proposals/{id} endpoint. The code was commented out because the akash proposer endpoint is returning an error for proposals created during genesis. On top of that, the workaround of checking for only post-genesis proposals (id > 3) doesn't work for sandbox/testnet.

Failing akash endpoint: https://akash-api.polkachu.com/gov/proposals/1/proposer

We need to:

  • Make sure proposer is returned for all proposal (pre or post-genesis)
  • Make sure this works with sandbox/testnet so no hardcoded proposal ids

We could also consider removing the endpoint or proposer entirely in the if there is no need for it anymore.

@Redm4x Redm4x added the bug Something isn't working label Mar 19, 2024
@anilmurty anilmurty added the sev3 severity 3 bug label May 7, 2024
@anilmurty
Copy link
Collaborator

lowered priority because this page is now on stats.akash.network and pretty hard to get to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sev3 severity 3 bug
Projects
Status: Backlog (not prioritized)
Development

No branches or pull requests

2 participants